This repository was archived by the owner on Mar 2, 2020. It is now read-only.
Open
Conversation
Conflicts: bundles/specmate-integration-test/src/com/specmate/test/integration/ModelGenerationTestDe.java bundles/specmate-integration-test/src/com/specmate/test/integration/ModelGenerationTestEn.java
junkerm
suggested changes
Aug 26, 2019
Owner
junkerm
left a comment
junkerm
left a comment
There was a problem hiding this comment.
- one of the model generation tests is failing
- a small comment regarding one of the utitlity functions
- please merge develop into this branch to check if all tests still run after that
| * @param s2 | ||
| * @return | ||
| */ | ||
| private boolean checkStringEquality(String s1, String s2) { |
Owner
There was a problem hiding this comment.
This method seems overly complex due to the many splits and replaces of differnt kinds of whitspace. How about:
- split strings with regex e.g. using \s* (any whitespace, any number of times)
- Add all non empty parts into a set
- Compare sets using equals
Additionally: I would opt to crate a class "TextUtit" in specmate-common and move the method there as a static method. I guess we can move more such methods there over time.
Collaborator
Author
1 similar comment
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trello